-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the 192-bit EC test case #779
Remove the 192-bit EC test case #779
Conversation
If you are referring to an issue pls provide a link not just a number. |
@pshipton This only happens at 11. Case 18320 is failed on this line of code. The size of 192 is not supported by a FIPS version of OpenSSL. This 192 size of EC key is not declared in other versions such as 17, 21 and next. For 11, the native code path will not be used, instead a java code will be used. |
Perhaps it makes more sense to just remove the 192-bit test from |
Remove the 192-bit test to align with other versions makes sense to me. |
d8f8829
to
6337cf4
Compare
Removed 192-bit test |
6337cf4
to
7a701cc
Compare
Isn't that just leaving the problem to be found by a customer? |
It's not clear that is the result: The failing test involves a replacement key-pair generator, not the one customers would be using. |
Please update the commit message and the description here to more accurately describe this change. |
7a701cc
to
8480b4e
Compare
updated |
This doesn't "implement" anything as the commit message and description say, instead it removes testing of a specific EC key size. Perhaps the summary should be (paraphrasing the last line and editing for grammar):
|
8480b4e
to
fc37570
Compare
Updated |
This patch eliminates the 192-bit EC test which causes exceptions seen in issue #18320. DefaultSignatureAlgorithm test was run in those Redhat OS based machines in a non-FIPS mode, but with a FIPS version of openssl. So, a 192-bit size of EC key pair generator is not allowed by the native code in a FIPS version of openssl. The code path went to a replacement EC key-pair generator Java implementation. issue: eclipse-openj9/openj9#18320
fc37570
to
c0fed93
Compare
Jenkins compile plinux jdk11 |
All plinux build systems are offline. |
Jenkins compile zlinux jdk11 |
This patch eliminates the 192-bit EC test which causes exceptions
seen in issue #18320.
DefaultSignatureAlgorithm test was run in those Redhat OS based machines
in a non-FIPS mode, but with a FIPS version of openssl. So, a 192-bit
size of EC key pair generator is not allowed by the native code in a
FIPS version of openssl. The code path went to a replacement EC key-pair
generator Java implementation.
issue: eclipse-openj9/openj9#18320