Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controls.Continuous.LimPID specifies wrong units #1316

Closed
mwetter opened this issue Mar 10, 2020 · 0 comments · Fixed by #1317
Closed

Controls.Continuous.LimPID specifies wrong units #1316

mwetter opened this issue Mar 10, 2020 · 0 comments · Fixed by #1317
Assignees
@mwetter

Comments

@mwetter
Copy link
Contributor

mwetter commented Mar 10, 2020

This model specifies k to have unit=1, but the unit of k is the inverse of the control error.
Simulating such a controller gives a warning in OpenModelica. To reproduce, simulate

Buildings.Controls.OBC.ASHRAE.G36_PR1.AHUs.MultiZone.VAV.Validation.Controller

in OMEdit. This model uses a similar controller that has the same incorrect unit specification.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwetter mwetter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Corrected unit specification for #1316 ibpsa/modelica-ibpsa
1 participant
@mwetter