Issue147 movers record #153
Conversation
This merges https://github.com/lbl-srg/modelica-buildings/pull/367/files to the Annex60 repository
|
@damienpicard : Can you please review. This is a big change that we want to have soon on the |
|
I will look at this tomorrow. |
| each min=0, each displayUnit="Pa") | ||
| "Fan or pump total pressure at these flow rates"; | ||
|
|
||
| // This is needed for OpenModelica. | ||
| // fixme: Check if this can be put into FlowMachineInterface instead of here. |
There was a problem hiding this comment.
Do you want to keep some fixme in the master?
| etaHyd = cha.efficiency(data=hydraulicEfficiency, r_V=r_V, d=hydDer); | ||
| etaMot = cha.efficiency(data=motorEfficiency, r_V=r_V, d=motDer); | ||
| etaHyd = cha.efficiency(per=per.hydraulicEfficiency, V_flow=VMachine_flow, d=hydDer, r_N=1, delta=1E-4); | ||
| etaMot = cha.efficiency(per=per.motorEfficiency, V_flow=VMachine_flow, d=motDer, r_N=1, delta=1E-4); | ||
| dpMachine = -dp; | ||
| VMachine_flow = -port_b.m_flow/rho_in; |
There was a problem hiding this comment.
Why is VMachine_flow = - port_b.m_flow/rho_in and not =port_a.m_flow/rho_in? rho_in is the density of inlet fluid...
There was a problem hiding this comment.
I will correct this. Using port_a.m_flow is better.
| "Volume flow rate vs. total pressure rise with correction for pump resistance added"; | ||
| // fixme check whether these branches are correct | ||
| // fixme check whether these branches are correct |
There was a problem hiding this comment.
Do these fixme still need to be solved?
There was a problem hiding this comment.
They are no longer needed. I will remove them.
|
For me, this branch can be merged after having addressed my few comments. |
Issue147 movers record. This closes #147
Merge new pumps and fans.
This will close #147