avoid Arc for already Send-able Services
#5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would prefer inverting the API just for ease of use, and the fact that the |
dpc
force-pushed
the
avoid-arc
branch
2 times, most recently
from
b45672f
to
6028417
Compare
ibraheemdev
reviewed
Sep 8, 2023
|
Perfect, thanks! |
|
Released in 0.3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re #4
The exact API is up for the debate. One one arcing internally makes things a bit easier for the user. On the other - I would expect most of real use will require internal
Arcing of stuff anyway, and could just avoid an extra dereference.I don't have strong opinions, and just wanted to confirm if it's possible in the first place. The
Pinstuff made me worried for a bit.