Support escaping '{' and '}' #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibraheemdev
force-pushed
the
escape-params
branch
from
9d498e6
to
4195add
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the last features I want to land as part of #35. It ended up being a lot more work than expected because of the way parameter normalizing/denormalizing works, but most of the new logic is contained within the
Unescapedtypes during insertion, so search is unaffected.This change also reworks
InsertErrorto be more clear.InsertError::InvalidParamSegmentnow represents an error within a/.../segment (i.e. multiple parameters/unsupported suffix), whileInsertError::InvalidParamrepresents any other parameter syntax related error.