Remove includeRoomsAsLights? #191
faanskit
started this conversation in
Show and tell
Replies: 1 comment 1 reply
-
I've been thinking about the Plejd rooms a bit too, see #152 To me, the implementation is quite lacking today, and I'd be quite happy to remove them code-wise. Functionality-wise, Plejd rooms is the only way (I know of) to multi-target lights (light groups). SO - with creative "rooming" you could actually get very quick state changes or transitions for many lights. But it gets quite complicated when lights inside the room has different brightnesses you want to transition from. Either way - the room hinting over MQTT I think is a very welcome change. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
With the introduction of Areas in Home Assistant and in particular the possibility for devices to publish their Suggested Area as released in version 2021.3., the includeRoomsAsLights as functions is maybe outdated and should possibly be deprecated.
In a coming PR, currently only available in a branch in my fork, I have implemented support for suggested_area.
All rooms configured in the Plejd App will be generated as Areas in Home Assistant, and devices will be connected to these areas. Devices can be moved to other areas in Home Assistant, as this is merely suggested areas.
In Home Assistant, Areas will appear in the Lovelace Ui.
![kontor](https://user-images.githubusercontent.com/10439868/117489090-75591300-af6d-11eb-9667-e8085e37c1b0.JPG)
The rationale for proposing to remove includeRoomsAsLights is simply because the function is now redundant. All devices in a room can be handled directly in the Ui:
![kontor_2](https://user-images.githubusercontent.com/10439868/117489266-b5b89100-af6d-11eb-8bf0-5b33d22ed0a4.JPG)
In fact, this is better since non-plejd devices can be connected to the same bulc on/off function:
Possible drawbacks:
But: To remove it will not really make a any difference, so maybe better to just let-it-be
Beta Was this translation helpful? Give feedback.
All reactions