-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the small schema additions #207
Conversation
Note that I only added integration tests involving the new attributes for the REST API, but not for SOAP. As far as I understand things, I would need an icat.client 4.10.0 in order to write such tests for the SOAP API. But I need a running icat.server 4.10.0 in order to build an icat.client 4.10.0, so there is a kind of a circular dependency. I guess the proper path would be:
This could still be done before the final release of 4.10.0. |
DOI vs PID Apologies in advance as this is not my area of expertise but we have DOI fields on Investigation, DataSet, DataCollection and DataFile. You have created PID fields for Instrument, ParameterType and Sample. I understand that PID is the more generic term but shouldn't we be consistent? Won't we be storing the same type of information in these fields? |
Good question. I guess there is no best solution. I would consider the attribute name But, in the end, it's an attribute name that is most likely never visible to the end user. |
Note: the failing travis test is due to the fact that travis first installs an old version of icat.server and undeploys it (in order to setup the JDBC connection pool as a side effect), but fails to run the provided schema upgrade script on the old database. If I run the test locally in the proper manner, they succeed. |
This implements the "smaller" schema additions and thus closes #198, closes #199, and closes #201. As these schema changes are purely additive, it should not create any compatibility issues.
It is assumed that this PR will be merged before the release of icat.server 4.10.0. This version number is mentioned in the release notes, the installation instructions, and the file names of the database upgrade scripts.