Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: auto generate declaration file #8

Merged
merged 1 commit into from
Apr 24, 2020
Merged

fix: auto generate declaration file #8

merged 1 commit into from
Apr 24, 2020

Conversation

ksocha
Copy link
Contributor

@ksocha ksocha commented Apr 23, 2020

TS declaration file should be auto generated during build. I also fixed some typings issues.

My knowledge of rollbar and its plugins is limited, so please treat this with caution.

@ksocha ksocha mentioned this pull request Apr 23, 2020
Closed
@icd2k3 icd2k3 self-requested a review April 24, 2020 15:32
icd2k3
icd2k3 approved these changes Apr 24, 2020
View reviewed changes
Copy link
Owner

@icd2k3 icd2k3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the hard work @ksocha!

@icd2k3 icd2k3 merged commit 250b85b into icd2k3:master Apr 24, 2020
@ksocha ksocha deleted the auto-generate-declaration-file branch April 24, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icd2k3 icd2k3 icd2k3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksocha @icd2k3