Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deep merge new attribute #16

Closed
wants to merge 1 commit into from

Conversation

WebPudge
Copy link

#13 修复 deepmerge中合并target问题。

souce中的key不存在于target中时报错 Error: target[key] is not iterable

报错示例如下:

const eslint = require('./eslint');
const deepmerge = require('./deepmerge');

// eslint 无 overrides key
// 此处会抛出错误 Error: target[key] is not iterable` 
module.exports = deepmerge(eslint, {
  overrides: [
    {
      files: ['*.js'],
      rules: {
        '@typescript-eslint/no-var-requires': 'off',
      },
    },
  ],
});

@WebPudge WebPudge changed the title fix: deep merge new attribute #13 fix: deep merge new attribute Aug 17, 2020
@fyangstudio
Copy link
Contributor

感谢反馈,新 @iceworks/spec 的PR 中修复了此问题。

#17

非常感谢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants