Model, fixed retry to save invalid model bug #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 1, 2018 13:42
Invalid model can't be saved even though its has been fixed to valid one
mruz
reviewed
Oct 1, 2018
| let fields = this->fields(this->getData(), !this->autoincrement); | ||
|
|
||
| if typeof this->primary == "array" { | ||
| let fields = array_diff_key(fields, primary); |
There was a problem hiding this comment.
Maybe we could remove it in the fields()? https://github.com/ice/framework/pull/202/files#diff-adc4d2a2f6f7dca511a6e8073769eb86R266
There was a problem hiding this comment.
create require to store the primary keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invalid model can't be re-saved even though its has been fixed to valid one