Fix the test_sampling.py test failures #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e robust. It still relies on magic numbers from 'I ran it one time and got these', but that's to be expected when testing a sampler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test_sampling.py relied on numbers found from the buggy InvCDF sampling before the fix in #19 . This updates the test with new numbers and replaces a hand-crafted truncated gaussian distribution in the test with an implementation from scipy, which directly gives the cdf values we want to test against.
In order to better ensure that things are working correctly, adding is also added to the InvCDF function. This ensures that the values at the edges - CDF values of 0 and 1 - return the right thing. Before, the edges were a little bit dodgy and could return values outside of [0,1].