-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEPRECATED: Merging oscNext high stats analysis latest changes #684
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re than 2 pipelines
…ting them, for data provenance
It looks like there are a lot of old commits in this branch that already should exist in the master branch... could this be rebased, please? |
…ect. Now checks the bins all match rather than the metric value.
@ts4051 what's the status of this? Do you think we can wrap-up this PR soon? |
I would like to review a few things first... and it would be nice if this could be rebased. I will see to it that I check it out tomorrow and have a look. |
Yes the rebase what is holding me up, will try and get to this tomorrow
…On Mon, Nov 22, 2021 at 5:51 PM Alexander Trettin ***@***.***> wrote:
I would like to review a few things first... and it would be nice if this
could be rebased. I will see to it that I check it out tomorrow and have a
look.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#684 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABMVI64F35II7G3EMZTIRKLUNJYKFANCNFSM5HSFTCYQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
ts4051
changed the title
Merging oscNext high stats analysis latest changes
DEPRECATED: Merging oscNext high stats analysis latest changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a merge of a number of changes implemented in recent months to support the oscNext high stats analyses.
Summary of changes:
Fix to bug in analysis fits where updates to params with multiple selections defined (e.g. mass orderings) are lost. This stopped sensitivity scans working for the numu disappearance analysis. The fix mostly involved removing taking copies of param objects, such as during the octant check.
Before scipy minimization begins, there is now a check to see if the initial params are already perfect (e.g. return metric == 0). If so, there is no need to minimize. This saves time, and avoids issues observed with the L-BFGS-B algorithm which can sometimes fail if the initial param values are exactly correct.
Added more metadata for failed fits.
Added smarter down-sampling of events, allowing breaking the events into arbitrary sized sub-populations, and selecting the desired sub-population. Used to create statistically independent templates with arbitrary statistics.
Added support for setting the
tex
member of theParam
class via config files.The
grid.py
stage (which creates fake input data on a grid, useful for making e.g. oscillograms) didn't work in PISA 4. This is now fixed.Neutrino decoherence re-integrated into the
nusquids.py
stage )this has been broken by recent updates as part of the sterile analysis)Some general performance improvements to the hypersurface code. No functional changes however, just better memory, file size, load times, error handling, etc. Also added additional data provenance.
Some ranges added to
nufitv40.cfg
.A few general added/improved comments, etc.