Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPRECATED: Merging oscNext high stats analysis latest changes #684

Closed
wants to merge 99 commits into from

Conversation

ts4051
Copy link
Contributor

@ts4051 ts4051 commented Nov 8, 2021

This is a merge of a number of changes implemented in recent months to support the oscNext high stats analyses.

Summary of changes:

  1. Fix to bug in analysis fits where updates to params with multiple selections defined (e.g. mass orderings) are lost. This stopped sensitivity scans working for the numu disappearance analysis. The fix mostly involved removing taking copies of param objects, such as during the octant check.

  2. Before scipy minimization begins, there is now a check to see if the initial params are already perfect (e.g. return metric == 0). If so, there is no need to minimize. This saves time, and avoids issues observed with the L-BFGS-B algorithm which can sometimes fail if the initial param values are exactly correct.

  3. Added more metadata for failed fits.

  4. Added smarter down-sampling of events, allowing breaking the events into arbitrary sized sub-populations, and selecting the desired sub-population. Used to create statistically independent templates with arbitrary statistics.

  5. Added support for setting the tex member of the Param class via config files.

  6. The grid.py stage (which creates fake input data on a grid, useful for making e.g. oscillograms) didn't work in PISA 4. This is now fixed.

  7. Neutrino decoherence re-integrated into the nusquids.py stage )this has been broken by recent updates as part of the sterile analysis)

  8. Some general performance improvements to the hypersurface code. No functional changes however, just better memory, file size, load times, error handling, etc. Also added additional data provenance.

  9. Some ranges added to nufitv40.cfg.

  10. A few general added/improved comments, etc.

bourdeet and others added 30 commits February 24, 2020 14:24
@atrettin
Copy link
Contributor

atrettin commented Nov 8, 2021

It looks like there are a lot of old commits in this branch that already should exist in the master branch... could this be rebased, please?

@philippeller
Copy link
Collaborator

@ts4051 what's the status of this? Do you think we can wrap-up this PR soon?

@atrettin
Copy link
Contributor

I would like to review a few things first... and it would be nice if this could be rebased. I will see to it that I check it out tomorrow and have a look.

@ts4051
Copy link
Contributor Author

ts4051 commented Nov 22, 2021 via email

@ts4051 ts4051 changed the title Merging oscNext high stats analysis latest changes DEPRECATED: Merging oscNext high stats analysis latest changes Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants