Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mesh2D primitive for rendering arbitrary geometry in iced_wgpu #140

Merged
merged 3 commits into from
Jan 3, 2020
Merged

Mesh2D primitive for rendering arbitrary geometry in iced_wgpu #140

merged 3 commits into from
Jan 3, 2020

Conversation

artursapek
Copy link
Contributor

@artursapek artursapek commented Jan 2, 2020 •
edited by hecrj
Loading

image

@artursapek artursapek changed the title WIP: Geometry2D primitive for arbitrary geometry in iced_native Geometry2D primitive for arbitrary geometry in iced_native Jan 2, 2020
@hecrj hecrj added the feature New feature or request label Jan 2, 2020
@hecrj hecrj added this to the 0.1.0 milestone Jan 2, 2020
hecrj
hecrj approved these changes Jan 2, 2020
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. It lays the foundations to implement a Canvas2D widget (see #32) and simpler widgets, like a color picker. Thank you! 🎉

I have renamed Geometry2D to Mesh2D and moved the types to iced_wgpu, as I think these are very basic GPU primitives and we are only using them in iced_wgpu::Primitive for now. I have also wrapped the Mesh2D in an Arc, so widgets can cache meshes if they need to.

Let me know what you think, and we can merge this!

@hecrj hecrj changed the title Geometry2D primitive for arbitrary geometry in iced_native Mesh2D primitive for rendering arbitrary geometry in iced_wgpu Jan 2, 2020
@artursapek
Copy link
Contributor Author

@hecrj those changes seem great to me. Thanks for taking it to the finish line.

@hecrj hecrj merged commit e4de213 into iced-rs:master Jan 3, 2020
@hatoo hatoo mentioned this pull request Jan 6, 2020
Merged
@hecrj hecrj mentioned this pull request Feb 18, 2020
Merged
@hecrj hecrj mentioned this pull request Apr 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@artursapek @hecrj