Left and right colors for slider rails #1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The rail having 2 vertical colors is on purpose! It's meant to allow creating a rail with a subtle shadow. Having different rail colors for left and right makes complete sense, however. |
|
oh it was lol. didn't event occur to me haha |
casperstorm
reviewed
Jan 26, 2023
casperstorm
reviewed
Jan 26, 2023
n1ght-hunter
changed the title
n1ght-hunter
changed the title
hecrj
force-pushed
the
fix_slider_colors
branch
from
1767fbe
to
de51bc3
Compare
hecrj
changed the title
hecrj
approved these changes
Apr 12, 2023
There was a problem hiding this comment.
Looks great! Thanks 🥳
I made some minor changes:
- Simplified the drawing logic in 45cfce3. We can draw the rail behind the handle. No need to subtract its width everywhere.
- Removed
border_widthsupport in c2cc9a8. I believe it could lead to weird-looking results with thick borders. - Changed the rail
border_radiusfor the built-in theme to2.0in 6e6804c. It looks nice! - Renamed
Rail::sizetowidthin 9b39a17. The way I see it, the width of a rail is similar to the width of a stroke.
We can wrap this up and merge! 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fixs
the rail color is vertical not horizontal
before:
after:
features added
added rail height and border radius to style
discussions
you can currently set the slider height but i think the height should be determined off the size of the handle or raildecided at this point i wont do this may make the changes at a later date. as i can see some advantages to having the height separate.
todo
need to fix vertical slider as well