migrated Image and ProgressBar widgets #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hecrj
requested changes
Aug 22, 2019
| /// ``` | ||
| /// use iced::Image; | ||
| /// | ||
| /// let image = Image::new("image"); |
There was a problem hiding this comment.
I would probably write something like:
# let my_image_handle = String::from("some_handle"); // This line will be hidden in docs
let image = Image::new(my_image_handle);That way, we remark the fact that the handle is generic.
| /// # Example | ||
| /// | ||
| /// ``` | ||
| /// use coffee::ui::ProgressBar; |
| /// A widget that displays a progress of an action. | ||
| /// | ||
| /// It implements [`Widget`] when the associated [`core::Renderer`] implements | ||
| /// the [`button::Renderer`] trait. |
|
I fixed the issues and merged the PR manually. Thank you again! 🎉 |
tarkah
pushed a commit
to tarkah/iced
that referenced
this pull request
Sep 2, 2022
Iced fixes for trade activity
hecrj
added a commit
that referenced
this pull request
Oct 29, 2022
Add `column!` and `row!` macros in `iced_pure`
CurryPseudo
pushed a commit
to CurryPseudo/iced
that referenced
this pull request
Apr 25, 2023
Move IME candidate window . sorry for big change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, I need to add renderers to this PR, but I had a problem with running the example. It fails with #1