Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Windows. #2472

Closed
wants to merge 1 commit into from
Closed

Conversation

ryankopf
Copy link

Would you be interested in supporting multiple - or no - windows in application?

This may alleviate the need for a separate Daemon setup, which duplicates a lot of what "application" already does.

If you think this is worth pursuing, I can create a more complete proposal, but this is a start of what it would look like.

Incomplete:

  • One window works and no windows works
  • Adding more windows than that doesn't work yet
  • Maybe each window can have its own task handler for open/close
  • There's could be complex task-assigning based on what window that might need to be thought about

At minimum though, something like this, or even just converting window: window::Settings to an Option, would simplify?

@ryankopf ryankopf marked this pull request as draft June 21, 2024 09:14
@max397574
Copy link

Perhaps I'm completely missunderstanding what you're doing here
But isn't this already implemented with #1964?

@ryankopf
Copy link
Author

Perhaps I'm completely missunderstanding what you're doing here But isn't this already implemented with #1964?

Maybe, let me reevaluate

@ryankopf ryankopf closed this Jun 21, 2024
@hecrj
Copy link
Member

hecrj commented Jun 21, 2024

This may alleviate the need for a separate Daemon setup, which duplicates a lot of what "application" already does.

No. Notice how you broke all the examples. Daemon precisely exists to make the complexity of multi-window applications opt-in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants