Add Placeholders to PickList #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hecrj
approved these changes
Jul 22, 2021
There was a problem hiding this comment.
This is great! Thank you 🙇
I have made some changes to remove some duplication and fix a minor issue with the hash_layout implementation.
Additionally, I have introduced a placeholder_color field to the Style of a PickList. This way, we can help the user differentiate between a selected option and a placeholder.
I think this should be ready to go! 🎉
|
Thanks for making those changes and catching the issue with the hash layout! The separate colour for the placeholder definitely makes sense, it might be difficult to tell otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This PR adds support for displaying a placeholder label when no value is currently selected in a PickList.
Closes #726.