-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a wrap widget #12
Conversation
This is a great widget. 👍 I hope I find the time tomorrow evening to take a closer look at it and to add the missing documentation. |
Alright, I've now updated the documentation of the code. 🙂 |
Cool, I will implement optional directions next. |
Currently supports optional direction, but alignment is not implemented, this part I don't have strong demand, therefore no strong desire to impl it. Because a lot of changes, the document also needs to be updated. I haven't implemented alignment yet, but I'll do it in the future if I have time.Of course, it would be nice to see if anyone is interested in making it happen ahead of me.I need you to help me mark this part in the document , to mark that this part has not been implemented yet. Thank you very much. |
OK, this is actually done, even the align has been implemented. |
Awesome work! 🙂 Is there a reason of why you are using two different structs for the direction instead of one enum? |
I’ve updated the example, why do I use different structs instead of enumerations because it’s better in performance? This is one of the reasons, mainly to correspond to iced’s row and column. |
I was just curious. I didn't know there was such a big difference in performance. Alright! Thank you very much for such a nice widget. 👍 |
Add a wrap widget
At present, horizontal direction can be used. My English is not good enough, so I need you to help me think about the document part.