-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TabBar/Tabs using a type instead of usize for active_tab #128
TabBar/Tabs using a type instead of usize for active_tab #128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I request you get this update with the current main. Also everything else looks good. would be nice to see an tab ID enum used in the example though.
# Conflicts: # src/graphics/tab_bar.rs # src/graphics/tabs.rs
The example you're searching is here or do you mean another place? In the TabBar example I am using usize as custom type. |
This reverts commit e896531.
…re leftovers from the merge to main
Ok, I believe I am done with the Feature request #124. Please review and feel free to squash-merge, when done. |
thank you for your hard work. |
Hey there!
I created the feature request #124 and since I didn't want to wait for it, I just implemented it.
It's not done yet but, I wanted to hear your impression, so that I won't run into a complete wrong direction.
TODO:
new
-function, but I am not sure if this is possible with this implementation. Any ideas?