TabBar/Tabs using a type instead of usize for active_tab #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andretietz
commented
Jun 2, 2023
andretietz
commented
Jun 2, 2023
andretietz
commented
Jun 2, 2023
genusistimelord
requested changes
Jun 2, 2023
# Conflicts: # src/graphics/tab_bar.rs # src/graphics/tabs.rs
|
The example you're searching is here or do you mean another place? In the TabBar example I am using usize as custom type. |
This reverts commit e896531.
…re leftovers from the merge to main
Closed
|
Ok, I believe I am done with the Feature request #124. Please review and feel free to squash-merge, when done. |
genusistimelord
approved these changes
Jun 5, 2023
|
thank you for your hard work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there!
I created the feature request #124 and since I didn't want to wait for it, I just implemented it.
It's not done yet but, I wanted to hear your impression, so that I won't run into a complete wrong direction.
TODO:
new-function, but I am not sure if this is possible with this implementation. Any ideas?