Show which item is selected in SelectionList
#48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kaiden42
reviewed
Feb 14, 2022
| @@ -50,12 +50,12 @@ default = [ | |||
| ] | |||
|
|
|||
| [dependencies] | |||
| iced_style = { git = "https://github.com/hecrj/iced.git", rev = "adce9e0" } | |||
| iced_style = { git = "https://github.com/iced-rs/iced.git", rev = "adce9e0" } | |||
There was a problem hiding this comment.
This change breaks every example (at least for me). This change would need to be taken on every example as well
Would you like to open up another PR with this changes and remove this change from this PR for now?
There was a problem hiding this comment.
yeah id request that he removes this change from his PR so we can go fix these in a separate PR.
Kaiden42
reviewed
Feb 14, 2022
| selected_text_color: Color::WHITE, | ||
| selected_background: Background::Color([0.4, 0.4, 1.0].into()), | ||
| selected_background: Background::Color([0.0, 1.0, 0.0].into()), |
There was a problem hiding this comment.
The background color's lightness is nearly indistinguishable from the color of the text. The text is really hard to read. Could you use another color like a dark green for the background or a more darker color like black for the text?
Kaiden42
requested changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an easy way to tell which item in a
SelectionListis currently selected by tracking the index of the currently selected item and styling it accordingly.Previously,
Style.selected_text_colorandStyle.selected_backgrounddefined the styling of the item that the mouse was hovering over. These have been renamed toStyle.hovered_text_colorandStyle.hovered_background, respectively, andStyle.selected_text_colorandStyle.selected_backgroundnow accurately refer to the styling applied to the currently selected item.I have verified that the
selection_listexample still works - no code changes were required.