Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix iOS background update performance issues #293

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Fix iOS background update performance issues #293

merged 1 commit into from
Jun 11, 2021

Conversation

stevesoltys
Copy link
Contributor

This avoids the memory leak / high CPU usage from an indefinite number of CADisplayLink being added to NSRunLoop.currentRunLoop.

It does this by removing the CADisplayLink from the loop when the UIView is offscreen (window is null).

@Alex009
Copy link
Member

Alex009 commented Jun 11, 2021

@stevesoltys thanks!
but current version of moko-widgets depends on bintray versions...i merge it, but can't publish

@Alex009 Alex009 added this to the 0.1.0-dev-21 milestone Jun 11, 2021
@Alex009 Alex009 merged commit b6c1fea into icerockdev:develop Jun 11, 2021
@stevesoltys stevesoltys deleted the bugfix/ios-performance branch June 11, 2021 19:21
@Alex009 Alex009 linked an issue Jul 15, 2021 that may be closed by this pull request
Remove displayLink usage #282
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alex009 Alex009 Alex009 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

Remove displayLink usage
2 participants
@stevesoltys @Alex009