Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enum with Fields Cleanup #685

Merged
merged 5 commits into from
Dec 12, 2023
Merged

Enum with Fields Cleanup #685

merged 5 commits into from
Dec 12, 2023

Conversation

InsertCreativityHere
Copy link
Member

This PR:

  • reduces our usage of 'enums with associated fields' in the compiler, opting for the simpler 'enum with fields'.
  • Changes fields to return a Vec<Field> instead of an Option<Vec<Field>> for easier use (None => vec![]).
  • Disallows using enums with fields as a dictionary key type

@InsertCreativityHere InsertCreativityHere merged commit acd154f into icerpc:main Dec 12, 2023
4 checks passed
@InsertCreativityHere InsertCreativityHere mentioned this pull request Dec 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@externl externl externl approved these changes

@ReeceHumphreys ReeceHumphreys ReeceHumphreys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@InsertCreativityHere @externl @ReeceHumphreys