Allow Settings Explicit Discriminants for Enums with Fields #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InsertCreativityHere
requested review from
externl,
bernardnormier and
ReeceHumphreys
bernardnormier
approved these changes
Dec 13, 2023
src/validators/enums.rs
Outdated
| check_bounds(enum_def, &Primitive::VarInt32, diagnostics); | ||
| // For enumerators in Slice2, values must fit within varint32 and be positive. | ||
| let varint32_max = Primitive::VarInt32.numeric_bounds().unwrap().1; | ||
| check_bounds(enum_def, (0, varint32_max), diagnostics); |
There was a problem hiding this comment.
I find this varint32_max odd. Why define this max since it's == int32_max?
There was a problem hiding this comment.
We definitely could.
I just thought it seemed cleaner to get the max from the actual Slice type, instead of the mapped type.
Using i32::MAX is obviously simpler though.
There was a problem hiding this comment.
I switched to using i32::MAX.
externl
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to set explicit discriminants for their enumerators, even if they have fields.
It also fixes the range of these discriminants so they must fit within [0, int32::MAX].