-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify git workflow to just be on one 'main' branch #131
Comments
Hello @weiji14. The development team/ICESat-2 project group during the Hackweek decided to transition to a development and master/main branch model in order to separate out the multiple directions of rapid development from the broader release schedule while maintaining a stable version on master. I'll note that at the time there was a not yet a I appreciate your concern for burdening maintainers, and I agree that there are likely some ways to simplify the process that don't require massive re-reviews by a few developers. Perhaps we could start a conversation on Discourse about this aspect (since it's not technically a code issue, but more of a discussion item) to brainstorm some alternative approaches? |
I just wanted to leave an update here for posterity: I just reduced the required reviews for merging into master (now main) from development from two reviews to one review, with maintainer status required to merge. I'm hoping this will reduce the review burden somewhat, while continuing to allow project teams the ability to work on development, review their sub-teams' PRs, and not have fear that they will "break something" because they are merging to main. |
Sounds good, and thanks again for the Zoom conversation clarifying the need for a separate development branch, I think it's good to make people feel confident that they can try things out without breaking stuff! P.S. I did a quick PR to rename master to main across the docs at #194 |
Could we just have one default 'main' branch, and delete the 'development' branch? I don't want everyone to spend time re-learning stuff, but since a major change is happening anyway at #130, now might be a good time to raise this issue.
Current state:
Future state:
The intention here is to reduce the burden on maintainers (specifically @JessicaS11) having to review code twice, and make sure that everyone points to 'development' all the time.
To be honest, I'm probably lacking context on why the master/development workflow was setup like so. If someone is after a stable release, wouldn't it be more likely that they would just use
pip install icepyx
instead of installing from Github?The text was updated successfully, but these errors were encountered: