Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interact with NSIDC API without paging #22

Closed
JessicaS11 opened this issue Feb 19, 2020 · 3 comments · Fixed by #87
Closed

interact with NSIDC API without paging #22

JessicaS11 opened this issue Feb 19, 2020 · 3 comments · Fixed by #87
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@JessicaS11
Copy link
Member

Paging is currently used to parse through granule search results, but it is not the recommended way to interact with the API. The Icesat2Data object and its methods should be modified to not use paging.

@JessicaS11 JessicaS11 added enhancement New feature or request help wanted Extra attention is needed labels Feb 19, 2020
@wallinb
Copy link
Contributor

wallinb commented May 28, 2020

@JessicaS11 I think you are referring to using 'scrolling' rather than paging with CMR correct? I'd be happy to take this on.

@JessicaS11
Copy link
Member Author

@wallinb - yes! That sounds right, and it would be great if you could make that happen. I'll add you to the organization so that you can create a branch for the work and push changes directly to the repo. By way of orientation: I suspect most of the changes will be in the granules module. We're also encouraging the addition of tests for any new code. Please keep in touch if you have any questions or want a more thorough intro. As always, suggestions and insights are welcome.

@JessicaS11 JessicaS11 linked a pull request Feb 2, 2022 that will close this issue
@JessicaS11
Copy link
Member Author

@wallinb left NSIDC in 2021 and this issue has languished. I picked up the open PR recently and in the process of updating it learned that the current recommended approach is to use the CMR-Search-After header rather than scrolling (which was preferred over paging). Thus, #87 has been updated to the latest and greatest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants