fixed lastMod to interpret MDTM time as GMT #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function lastMod relies on the FTP command MDTM. The MDTM command returns time strings that look like 19990929043300 meaning 1999-09-29 04:33:00. According to RFC 3659 these times are in GMT, which makes sense. However, they were passed directly into the constructor for a Date object, meaning they were interpreted as local time. By adding a Z to the end of the string so it looks like 1999-09-29T04:33:00Z the Date constructor will interpret them correctly.