Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove retriction to accept negative numbers as well #433

Merged
merged 1 commit into from
Jul 19, 2024
Merged

remove retriction to accept negative numbers as well #433

merged 1 commit into from
Jul 19, 2024

Conversation

lindaxiang
Copy link
Contributor

Related to #432

Test cases in QA:

  • Dictionary version: 130.2
  • Program: MONSTAR-JP, using the following specimen file. It contains specimens which have negative specimen_acquisition_interval.

specimen_v1.17.txt(change .txt to .tsv when submission)

bhavikbhagat93
bhavikbhagat93 reviewed Jul 18, 2024
View reviewed changes
Copy link

@bhavikbhagat93 bhavikbhagat93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since there is no value restriction on the field now, "restrictions" string can be removed?

Should there be a regex to only accept numbers?

@lindaxiang
Copy link
Contributor Author

since there is no value restriction on the field now, "restrictions" string can be removed?

Should there be a regex to only accept numbers?

@bhavikbhagat93
valueType is defined as integer
restrictions is still needed to indicate this is a required field.

@lindaxiang lindaxiang merged commit 5eb6706 into develop Jul 19, 2024
@lindaxiang lindaxiang deleted the 432_allow_interval_negative branch July 19, 2024 20:42
@lindaxiang lindaxiang mentioned this pull request Jul 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhavikbhagat93 bhavikbhagat93 bhavikbhagat93 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lindaxiang @bhavikbhagat93