Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the incorrect fetch partial parsing #132

Merged
merged 1 commit into from
May 7, 2022
Merged

Fix the incorrect fetch partial parsing #132

merged 1 commit into from
May 7, 2022

Conversation

icgood
Copy link
Owner

@icgood icgood commented May 7, 2022

Fix #131

The original implementation interpreted the partial fetch arguments as a start and end octet, but the RFC states they are a start octet and a length. This also causes incorrect parsing failures because there was a check that the first number was less than the second number, which does not make sense with corrected assumptions.

Fix #131

The original implementation interpreted the partial fetch arguments as
a start and end octet, but the RFC states they are a start octet and a
length. This also causes incorrect parsing failures because there was a
check that the first number was less than the second number, which does
not make sense with corrected assumptions.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0004%) to 91.046% when pulling 3cf851e on fix-partial into 73c52f8 on main.

@icgood icgood merged commit 81c0e46 into main May 7, 2022
@icgood icgood deleted the fix-partial branch May 7, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mail app: BAD UID FETCH: Invalid arguments.
2 participants