Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not encode url characters in response headers #17

Merged
merged 1 commit into from
Apr 21, 2016
Merged

Do not encode url characters in response headers #17

merged 1 commit into from
Apr 21, 2016

Conversation

jvasseur
Copy link
Contributor

@jvasseur jvasseur commented Apr 7, 2016

We need to allow "?" in response headers to allow redirecting to an url with a query string.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.346% when pulling 39f5342 on jvasseur:fix-header-encoding into 0681d28 on icicleio:v0.3.x.

@jvasseur
Copy link
Contributor Author

ping @trowski

@trowski
Copy link
Contributor

trowski commented Apr 21, 2016

Sorry, totally missed this here somehow. Looks great!

I wonder then if some other characters should be excluded, like # and @?

@jvasseur
Copy link
Contributor Author

# should probably be allowed too. Not sure about @, can we redirect to an url with some user information ?

@trowski
Copy link
Contributor

trowski commented Apr 21, 2016

Not a common use-case I'm sure, but I don't see why not.

@jvasseur
Do not encode url characters in response headers
72ee69b 
Allow @, # and ? in response headers to allow redirecting to urls containing them.
@jvasseur
Copy link
Contributor Author

Updated to allow # and @.

@jvasseur jvasseur changed the title Do not encode "?" in response headers Do not encode url characters in response headers Apr 21, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.346% when pulling 72ee69b on jvasseur:fix-header-encoding into 0681d28 on icicleio:v0.3.x.

@trowski trowski merged commit 69e66ac into icicleio:v0.3.x Apr 21, 2016
@jvasseur jvasseur deleted the fix-header-encoding branch April 21, 2016 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jvasseur @coveralls @trowski