Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix example code #18

Closed
wants to merge 1 commit into from
Closed

Fix example code #18

wants to merge 1 commit into from

Conversation

tyx
Copy link

@tyx tyx commented Jun 21, 2016

Or I miss something ?

@tyx
Fix example code
3d305b1 
Or I miss something ?
@coveralls
Copy link

Coverage Status

Coverage remained the same at 58.326% when pulling 3d305b1 on tyx:patch-1 into efd477d on icicleio:master.

@sagebind
Copy link

Your PR is against the master branch, which is the 2.0 series of Icicle that is PHP 7+. You are supposed to use return to return values (and yield from to await on things).

@tyx
Copy link
Author

tyx commented Jun 22, 2016

my bad

@tyx tyx closed this Jun 22, 2016
@tyx tyx deleted the patch-1 branch June 22, 2016 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tyx @coveralls @sagebind