Added GB using a new Register that calls HMRC's VAT API #62
Conversation
GB using HMRC VAT number API
test kwarg and add tests
|
It would be good to get this merged now it has been approved! |
| VIES_REGISTRY = ViesRegistry() | ||
| HMRC_REGISTRY = HMRCRegistry() |
There was a problem hiding this comment.
The comment "VIES registry instance." should be below line 59 and a new one should be added for HMRC_REGISTRY.
| @@ -10,6 +10,7 @@ | |||
| 'ES', # Spain. | |||
| 'FI', # Finland. | |||
| 'FR', # France. | |||
| 'GB', # United Kingdom. | |||
There was a problem hiding this comment.
Shouldn't this say "Great Britain" ? There is some difference: https://www.dictionary.com/e/great-britain-vs-uk-vs-england/#:~:text=Quick%20summary,Scotland%2C%20and%20Wales%20are%20situated.
There was a problem hiding this comment.
Set the comment to United Kingdom because it was that on version 1.3.6, felt it made sense to keep it the same.
The API accepts a UK VAT number so maybe it should be UK instead of GB.
| @@ -243,6 +243,14 @@ def get_vat_rate(self, item_type): | |||
| return super(MtVatRules, self).get_vat_rate(item_type) | |||
|
|
|||
|
|
|||
| class GbVatRules(ConstantEuVatRateRules): | |||
| """VAT rules for United Kingdom. | |||
There was a problem hiding this comment.
Should be "Great Britain" is we use "GB".
There was a problem hiding this comment.
See here: https://www.iso.org/obp/ui/#iso:code:3166:GB
GB is the Alpha 2 Code however it refers to the United Kingdom of Great Britain and Northern Ireland usually referred to as just the United Kingdom or UK. Using Great Britain would exclude Northern Ireland and Northern Ireland business do get GB VAT numbers therefore the United Kingdom is the correct form in this instance.
|
@mountinash789 Thank you for contributing, Rowan. I added a few comments regarding comments. It should be good to merge when these are updated. |
|
Hello, do you have an update about this PR? Any chance to have it released soon? Thanks |
|
Hello, are there any updates or follow-up actions on this? |
|
@MathieuLamiot Ok, I'll merge this one. Can you help resolve the conflicts and update from Master? |
|
I don't have write access to oraclefinance so:
|
No description provided.