Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix root path for user data #18

Closed
wants to merge 2 commits into from

Conversation

ikopytko
Copy link

Currently saving in android version is not available because of broken path. This path will fix it.

@PerlinWarp
Copy link
Member

PerlinWarp commented Jan 30, 2021

Hey Ivan, thanks for this, where did you grab the apk from? Did you build it yourself?
Are you on the Discord, if so please dm me

@ikopytko
Copy link
Author

Yes, I'm building it. Tried a bunch of different forks before and this one is the closest to the working version, just made a couple mods. I'll join the discord

@mikeskydev mikeskydev added the bugfix Something has been fixed label Jan 30, 2021
@mikeskydev
Copy link
Member

Hey, thanks for the PR! We've decided to fix this by returning to the original published SDK version, 26. In the future we'll upgrade to the correct saving permissions instead of changing the manifest, see #23.

@mikeskydev
Copy link
Member

After some thought, we'd like to move ahead with this following the discussion in #23. @ikopytko Please could you target the fix to main instead?

@ikopytko
Copy link
Author

Yes, I'll create a new PR as there is no option to reopen existing one nor edit target branch

@ikopytko ikopytko mentioned this pull request Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something has been fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants