Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 90Hz if available on Oculus #269

Closed
wants to merge 1 commit into from
Closed

Use 90Hz if available on Oculus #269

wants to merge 1 commit into from

Conversation

mikeage
Copy link
Member

@mikeage mikeage commented Aug 2, 2022

No description provided.

@mikeage mikeage marked this pull request as draft August 2, 2022 11:33
@mikeage mikeage requested a review from mikeskydev August 2, 2022 11:33
@mikeage
Copy link
Member Author

mikeage commented Aug 2, 2022 •
edited
Loading

[not tested yet; waiting for the CI builds]

@mikeage mikeage mentioned this pull request Aug 2, 2022
Draft
@mikeage
Copy link
Member Author

mikeage commented Aug 2, 2022

works on Q2. My Q1 is currently unavailable

@mikeage mikeage marked this pull request as ready for review August 2, 2022 19:03
@mikeskydev
Copy link
Member

mikeskydev commented Aug 5, 2022 •
edited
Loading

@andybak's comment in #108 has got me thinking if default is the best idea again 😅 I really wish there was a platform agnostic way to display the options to users, but as we've found that's not available on all platforms as of yet.

@mikeage
Copy link
Member Author

mikeage commented Aug 5, 2022

We can go back to the config file idea if we want.

Personally, I'm still concerned that we have no idea what our actual CPU (GPU?) budget looks like in the real world

@mikeskydev mikeskydev added the enhancement Feature added label Aug 25, 2022
@mikeskydev mikeskydev force-pushed the feature/xr_v2 branch 2 times, most recently from 79ee667 to b9c11bd Compare September 9, 2022 15:15
@mikeskydev mikeskydev changed the base branch from feature/xr_v2 to main September 12, 2022 08:29
@andybak andybak marked this pull request as draft February 24, 2023 12:07
@mikeskydev
Copy link
Member

I think #108 will fit us better as an optional solution for anyone who wants it, rather than anything automatic, for performance reasons!

@mikeskydev mikeskydev closed this Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeskydev mikeskydev Awaiting requested review from mikeskydev

Assignees
No one assigned
Labels
enhancement Feature added
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeage @mikeskydev