Add buttons to titles #172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mond1c
requested changes
Apr 9, 2024
| <Box display="flex"> | ||
| <ShowPresetButton className='block' onClick={onShow} active={data.shown}/> | ||
| <IconButton color="primary" onClick={() => { | ||
| data.settings.preset = "title_left.svg"; |
| onEdit(data); | ||
| }}>L</IconButton> | ||
| <IconButton color="primary" onClick={() => { | ||
| data.settings.preset = "title_right.svg"; |
irdkwmnsb
reviewed
Apr 9, 2024
| <Box display="flex"> | ||
| <ShowPresetButton className='block' onClick={onShow} active={data.shown}/> | ||
| <IconButton color="primary" onClick={() => { | ||
| data.settings.preset = "title_left.svg"; |
There was a problem hiding this comment.
Hardcoded value. This preset needs to be able to change. It's good for what it's worth. But maybe we can add some sort of logic or interface to be able to add more such buttons, or less of such buttons?
irdkwmnsb
reviewed
Apr 10, 2024
| <Box display="flex"> | ||
| <ShowPresetButton className='block' onClick={onShow} active={data.shown}/> | ||
| <IconButton color="primary" onClick={() => { | ||
| data.settings.preset = "title_left.svg"; |
There was a problem hiding this comment.
React doesn't like when props are mutated. Here you are mutating data. This is prone to bugs
|
Closed in favour of #175 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.