Fix writing extra data when updating Zip64 entries #314
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WriteCentralDirectoryHeader currently checks IsZip64Forced when deciding to write -1 to the base size fields ZipFile.cs#L2174 but not when writing the extra data ZipFile.cs#L2208, so the length doesn't get written.
This changes it to check in both places, and adds a test
Assuming that the length field and extra data should always be in sync (would you ever set size to -1 and not write the extra data?), might be better to set some 'wantsExtraSize' flags rather than checking ((entry.Size >= 0xffffffff) || otherFlags) in two places?
Closes #310.
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.