Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues discovered in beta release v1.2.0 #162

Merged
merged 7 commits into from
Jul 21, 2021

Conversation

rogerfraser
Copy link
Member

Overview

This pull request introduces the following fixes and enhancements:

Fixes

  • Fix an issue in import relating to the renaming of sites with discontinuities and every occurrence of a discontinuity site in the imported measurements (identified by @harry093 in discussion Beta release v1.2.0 of DynAdjust #149).
  • Fix a defect in FindXercesC.cmake, where installation failed to find a pre-existing installation of xerces-c in /opt/xerces-c/3.1.4
  • Fix issue Deflection of vertical correction incorrectly applied to zenith angles #160 and update corresponding formula in DynAdjust User's Guide
  • Fix an issue in adjust relating to archiving the estimated station uncertainties for simultaneous adjustments to *-rva.mtx. This defect led to strange values for SD(e), SD(n) and SD(up) in *simult.adj files when executing adjust in report results mode (i.e. --report-results)

Enhancements

  • Minor improvements to comments
  • Remove unused code
  • Minor code enhancements

@coveralls
Copy link
Collaborator

coveralls commented Jul 21, 2021

Coverage Status

Coverage increased (+0.9%) to 82.143% when pulling 213ed3e on rogerfraser:master into dacfbae on icsm-au:master.

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #162 (213ed3e) into master (dacfbae) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
+ Coverage   82.34%   82.37%   +0.02%     
==========================================
  Files         117      117              
  Lines       32464    32448      -16     
==========================================
- Hits        26734    26729       -5     
+ Misses       5730     5719      -11     
Impacted Files Coverage Δ
dynadjust/dynadjust/dnaadjust/dnaadjust.cpp 89.15% <100.00%> (-0.01%) ⬇️
dynadjust/include/io/dnaiosnx.hpp 100.00% <100.00%> (ø)
...nadjust/include/measurement_types/dnadirection.cpp 89.87% <100.00%> (+0.07%) ⬆️
...ust/include/functions/dnatemplatedatetimefuncs.hpp 83.84% <0.00%> (-0.49%) ⬇️
dynadjust/dynadjust/dnaadjust/dnaadjust.hpp 96.36% <0.00%> (+1.81%) ⬆️
...t/dynadjust/dnaadjustwrapper/dnaadjustprogress.cpp 76.79% <0.00%> (+4.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dacfbae...213ed3e. Read the comment docs.

@rogerfraser rogerfraser merged commit 720574b into icsm-au:master Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants