Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to prevent column overrun in fixed-width output files #83

Merged
merged 3 commits into from
Mar 13, 2021

Conversation

rogerfraser
Copy link
Member

This pull request fixes #78 by formatting the output of larger-than-expected values, such that they fit within the respective column widths in .adj and .cor files. As the new print function (StringFromTW) is adaptive and time consuming, this formatting is performed when an adjustment appears to be questionable or troublesome (i.e. very large measurement corrections or n-stat values).

@codecov-io
Copy link

Codecov Report

Merging #83 (215fb1c) into master (cfd12d8) will decrease coverage by 0.05%.
The diff coverage is 51.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
- Coverage   59.31%   59.26%   -0.06%     
==========================================
  Files         117      117              
  Lines       33769    33876     +107     
==========================================
+ Hits        20029    20075      +46     
- Misses      13740    13801      +61     
Impacted Files Coverage Δ
dynadjust/dynadjust/dnaadjust/dnaadjust.hpp 94.54% <ø> (ø)
dynadjust/include/functions/dnastrmanipfuncs.hpp 69.74% <0.00%> (-9.30%) ⬇️
dynadjust/dynadjust/dnaadjust/dnaadjust.cpp 59.74% <55.97%> (-0.36%) ⬇️
...t/dynadjust/dnaadjustwrapper/dnaadjustprogress.cpp 50.82% <0.00%> (-0.56%) ⬇️
dynadjust/dynadjust/dnaimport/dnainterop.cpp 55.84% <0.00%> (+0.03%) ⬆️
...adjust/dynadjust/dnaplotwrapper/dnaplotwrapper.cpp 73.42% <0.00%> (+2.70%) ⬆️
...st/dynadjust/dnaimportwrapper/dnaimportwrapper.hpp 58.33% <0.00%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfd12d8...215fb1c. Read the comment docs.

@rogerfraser rogerfraser merged commit 5596fe4 into icsm-au:master Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Column overrun on ADJ file
2 participants