Extend discontinuity renaming functionality, bug fix and other enhancements #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses #15 in the context of import, fixes a defect in the output of station uncertainties in the adj file, and provides some general enhancements that deal with certain compiler warnings and Codacy issues. In relation to #15, import now applies discontinuity renaming to station names imported in DNA and DynaML files and takes this renaming into account when supplying station names on the command line for
--include-stns-assoc-msrsor--exclude-stns-assoc-msrs. A sample discontinuity file (disconts20201205.snx) has been added to the sampleData folder, and new test scripts have been added.