Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create global, standard "isMobile" utility #930

Open
KevinWu098 opened this issue Feb 29, 2024 · 0 comments
Open

Create global, standard "isMobile" utility #930

KevinWu098 opened this issue Feb 29, 2024 · 0 comments
Labels
codefix Refactoring or improving the codebase Stale

Comments

@KevinWu098
Copy link
Member

There's roughly 50 instances of "isMobile" across 14 files and they're all of vaguely different implementations. Most refer to screen width, some at 750px and others at 960px. Others refer to the actual device.

In short, create or add to an existing utilities file and standardize the breakpoints.

@KevinWu098 KevinWu098 added the codefix Refactoring or improving the codebase label Feb 29, 2024
@github-actions github-actions bot added the Stale label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codefix Refactoring or improving the codebase Stale
Projects
Status: Backlog 🥱
Development

No branches or pull requests

1 participant