Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS\SSL #5

Closed
bararchy opened this issue Sep 29, 2017 · 5 comments
Closed

TLS\SSL #5

bararchy opened this issue Sep 29, 2017 · 5 comments

Comments

@bararchy
Copy link

Is there a way to pass in a context to use for SSL connection ?
I looked at Halite::Options but didn't find it.

@icyleaf
Copy link
Owner

icyleaf commented Sep 29, 2017

This is next step, completed basic request verbs first.
Thanks for asking.

@bararchy
Copy link
Author

@icyleaf Sure, I'll watch for it, when it's ready I'll start using your client :)
Thanks for all the good work

icyleaf added a commit that referenced this issue Oct 9, 2017
@icyleaf
Copy link
Owner

icyleaf commented Oct 9, 2017

The code is not under the tests, because i have no idea how to test, and i found nothing in crystal specs about tls/ssl, but you can try it. This implement based on Crystal's built-in HTTP::Client.new(uri : URI, tls = nil) method.

@bararchy
Copy link
Author

bararchy commented Oct 9, 2017

@icyleaf Thanks for adding it, I'll test it today :)

@bararchy
Copy link
Author

bararchy commented Oct 9, 2017

Working on Crystal 0.23.1, Halite: HEAD.
Can be closed.

@bararchy bararchy closed this as completed Oct 9, 2017
@icyleaf icyleaf added the bug label Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants