Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEFECT] Workshop ARMA needs to be retrained. #206

Closed
10 tasks done
dylanjm opened this issue Sep 2, 2022 · 1 comment
Closed
10 tasks done

[DEFECT] Workshop ARMA needs to be retrained. #206

dylanjm opened this issue Sep 2, 2022 · 1 comment
Labels
defect Something isn't working

Comments

@dylanjm
Copy link
Collaborator

dylanjm commented Sep 2, 2022


Defect Description

Due to some recent changes to the ARMA, we need to retrain the ARMA pk file in the workshop.

Traceback (most recent call last):
  File "/Users/mcdodj/Documents/projects/HERON/src/main.py", line 119, in <module>
    sim.read_input(args.xml_input_file) # TODO expand to use arguments?
  File "/Users/mcdodj/Documents/projects/HERON/src/main.py", line 53, in read_input
    objects = input_loader.parse(inp, location, self.messageHandler)
  File "/Users/mcdodj/Documents/projects/HERON/src/../../HERON/src/input_loader.py", line 104, in parse
    case.initialize(components, sources)
  File "/Users/mcdodj/Documents/projects/HERON/src/../../HERON/src/Cases.py", line 668, in initialize
    src.checkValid(self, components, sources)
  File "/Users/mcdodj/Documents/projects/HERON/src/../../HERON/src/Placeholders.py", line 199, in checkValid
    structure = hutils.get_synthhist_structure(self._target_file)
  File "/Users/mcdodj/Documents/projects/HERON/src/../../HERON/src/_utils.py", line 124, in get_synthhist_structure
    meta = rom.writeXML().getRoot()
  File "/Users/mcdodj/Documents/projects/raven/ravenframework/Models/ROM.py", line 599, in writeXML
    engines[0].writeXML(xml)
  File "/Users/mcdodj/Documents/projects/raven/ravenframework/SupervisedLearning/ROMCollection.py", line 1604, in writeXML
    step.writeXML(newNode, targets, skip)
  File "/Users/mcdodj/Documents/projects/raven/ravenframework/SupervisedLearning/ROMCollection.py", line 977, in writeXML
    Segments.writeXML(self, writeTo, targets, skip)
  File "/Users/mcdodj/Documents/projects/raven/ravenframework/SupervisedLearning/ROMCollection.py", line 401, in writeXML
    rom.writeXML(newNode, targets, skip)
  File "/Users/mcdodj/Documents/projects/raven/ravenframework/SupervisedLearning/ARMA.py", line 1394, in writeXML
    armaNode.append(xmlUtils.newNode('std', text=arma.sigma))
  File "/usr/local/Caskroom/miniconda/base/envs/raven_libraries/lib/python3.7/site-packages/statsmodels/base/wrapper.py", line 34, in __getattribute__
    obj = getattr(results, attr)
AttributeError: 'ARMAResults' object has no attribute 'sigma'
 ... Errors were encountered while running HERON.

For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or task?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
@dylanjm dylanjm added the defect Something isn't working label Sep 2, 2022
dylanjm added a commit to dylanjm/HERON that referenced this issue Sep 19, 2022
@dylanjm dylanjm mentioned this issue Sep 19, 2022
9 tasks
dylanjm added a commit to dylanjm/HERON that referenced this issue Sep 19, 2022
BotrosHanna-INL added a commit that referenced this issue Sep 19, 2022
@dylanjm
Copy link
Collaborator Author

dylanjm commented Sep 19, 2022

Approved to close via #209

@dylanjm dylanjm closed this as completed Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant