-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toggle tax #131
Toggle tax #131
Conversation
tests/integration_tests/mechanics/cashflows/Analytic_CashFlow.xmcd
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no edits to the changes. Everything looks good.
Job CentOS 8 on c4b4dbe : invalidated by @PaulTalbot-INL testing against new TEAL version |
@PaulTalbot-INL I think you'll need to rebase with the framework fixes and fix conflicts for these to pass. |
c00ecbd
to
b8ee45b
Compare
…s and discount rates through to TEAL is working properly based on qualifiers (taxable,etc) in the components
LGTM. A few changes were made to the original PR and tests have been verified to pass on Windows OS. Going to merge now. |
Pull Request Description
What issue does this change request address?
Closes #126
#265
What are the significant changes in functionality due to this change request?
Allows "taxable" to be toggled for all CashFlows, and tests that they work as expected analytically in the cashflow mechanics regression test.
This removes the deprecation from that test, so a new test is added explicitly to cover depreciation cashflows.
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.