Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistence option for optimizer #159

Merged
merged 6 commits into from
May 13, 2022
Merged

Persistence option for optimizer #159

merged 6 commits into from
May 13, 2022

Conversation

mgarrouste
Copy link

@mgarrouste mgarrouste commented May 12, 2022


Pull Request Description

What issue does this change request address?

Persistence option not available for optimization in HERON
Issue #160

What are the significant changes in functionality due to this change request?

User will be able to define persistence for the optimization in HERON and default value is provided otherwise.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large tes.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
  • 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

dylanjm
dylanjm previously approved these changes May 13, 2022
Copy link
Collaborator

@dylanjm dylanjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these changes look good to me and the new addition is properly tested.

@dylanjm
Copy link
Collaborator

dylanjm commented May 13, 2022

@mgarrouste Can you create and issue in HERON and reference it here? Thanks!

@mgarrouste
Copy link
Author

Re-golded the optimization settings test, created an issue for this and added it in the PR description

@PaulTalbot-INL PaulTalbot-INL linked an issue May 13, 2022 that may be closed by this pull request
10 tasks
@dylanjm dylanjm merged commit fea2cad into idaholab:devel May 13, 2022
@mgarrouste mgarrouste deleted the persistenceOptimizer branch October 18, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Persistence option for Optimizer
2 participants