Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom macro parameter #55

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

dylanjm
Copy link
Collaborator

@dylanjm dylanjm commented Oct 20, 2020


Pull Request Description

closes #54

Adds a year_variable as a subnode to the time_discritization node.

Adds steps in a modifying function to add year_variable to GRO_dispatch groups.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large tes.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
  • 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

PaulTalbot-INL
PaulTalbot-INL previously approved these changes Oct 20, 2020
Copy link
Collaborator

@PaulTalbot-INL PaulTalbot-INL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these changes look good; I suspect you'll need to either retrain the sine ARMA using "year", or add the year name node to the other test cases, or default to "Year" instead of "year". Any of the three is fine to me.

--------
Pull Request Description
--------

closes idaholab#54

Adds a `year_variable` as a subnode to the `time_discritization` node.

Adds steps in a modifying function to add `year_variable` to GRO_dispatch groups.

----------------
For Change Control Board: Change Request Review
----------------

The following review must be completed by an authorized member of the Change Control Board.

- [ ] 1. Review all computer code.

- [ ] 2. If any changes occur to the input syntax, there must be an accompanying
change to the user manual and xsd schema. If the input syntax change deprecates
existing input files, a conversion script needs to be added (see Conversion
Scripts).

- [ ] 3. Make sure the Python code and commenting standards are
respected (camelBack, etc.) - See on the
[wiki](https://github.com/idaholab/HERON/wiki/Code-Standards) for details.

- [ ] 4. Automated Tests should pass.

- [ ] 5. If significant functionality is added, there must be tests added to check
this. Tests should cover all possible options.  Multiple short tests are preferred
over one large tes.

- [ ] 6. If the change modifies or adds a requirement or a requirement based test
case, the Change Control Board's Chair or designee also needs to approve the
change.  The requirements and the requirements test shall be in sync.

- [ ] 7. The merge request must reference an issue.  If the issue is closed, the
issue close checklist shall be done.

- [ ] 8. If an analytic test is changed/added, the the analytic documentation must
be updated/added.

- [ ] 9. If any test used as a basis for documentation examples have been changed,
the associated documentation must be reviewed and assured the text matches the
example.
Copy link
Collaborator

@PaulTalbot-INL PaulTalbot-INL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@PaulTalbot-INL PaulTalbot-INL merged commit 3583b12 into idaholab:devel Oct 21, 2020
@dylanjm dylanjm deleted the arma-year-input branch April 11, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Custom macro parameter
2 participants