Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing and simplifying CI/CD release process. #418

Merged
merged 96 commits into from
Jun 26, 2024

Conversation

MicahGale
Copy link
Collaborator

@MicahGale MicahGale commented Jun 24, 2024

Description

This simplifies our CD process by making it more manual. This is done by:

  • Removing all automatic versioning (via github-tag-action).
  • Relying on an admin to update the changelog version numbers, and create a new tag.
  • Relying on an admin to manually merge and push this merge. This is necessary because GH will always try to make a new commit which will make setuptools_scm think this is a dev release
  • Verify that this is not a dev release

Fixes #407, Fixes #403, Fixes #402.

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@MicahGale MicahGale linked an issue Jun 24, 2024 that may be closed by this pull request
@MicahGale MicahGale self-assigned this Jun 24, 2024
@MicahGale MicahGale added documentation Improvements or additions to documentation bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error". CI/CD code improvement A feature request that will improve the software and its maintainability, but be invisible to users. labels Jun 24, 2024
@MicahGale
Copy link
Collaborator Author

This depends on #417

@MicahGale MicahGale requested a review from tjlaboss June 24, 2024 22:06
@MicahGale
Copy link
Collaborator Author

Workflow showing that this will not deploy if the tag isn't done properly. https://github.com/MicahGale/MontePy/pull/7

@MicahGale
Copy link
Collaborator Author

MicahGale commented Jun 24, 2024

Successful run. https://github.com/MicahGale/MontePy/actions/runs/9653118535 These tests were done with similar branch and tag protection rules in place.

@MicahGale MicahGale marked this pull request as ready for review June 24, 2024 22:26
@MicahGale MicahGale mentioned this pull request Jun 25, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jun 25, 2024

Pull Request Test Coverage Report for Build 9662665271

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.223%

Totals Coverage Status
Change from base Build 9622313437: 0.0%
Covered Lines: 5750
Relevant Lines: 5854

💛 - Coveralls

@idaholab idaholab deleted a comment from coveralls Jun 25, 2024
@idaholab idaholab deleted a comment from coveralls Jun 25, 2024
@idaholab idaholab deleted a comment from coveralls Jun 25, 2024
@idaholab idaholab deleted a comment from coveralls Jun 25, 2024
@idaholab idaholab deleted a comment from coveralls Jun 25, 2024
@idaholab idaholab deleted a comment from coveralls Jun 25, 2024
@idaholab idaholab deleted a comment from coveralls Jun 25, 2024
@MicahGale MicahGale requested a review from tjlaboss June 25, 2024 22:03
@MicahGale MicahGale enabled auto-merge (squash) June 25, 2024 22:07
@MicahGale MicahGale disabled auto-merge June 26, 2024 18:25
@MicahGale MicahGale enabled auto-merge (squash) June 26, 2024 19:04
@MicahGale MicahGale merged commit 1df0cf5 into develop Jun 26, 2024
14 checks passed
@MicahGale MicahGale deleted the 407-bugs-in-cicd-workflow branch June 26, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error". CI/CD code improvement A feature request that will improve the software and its maintainability, but be invisible to users. documentation Improvements or additions to documentation
Projects
None yet
3 participants