-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ver-1fd case #125
Add Ver-1fd case #125
Conversation
Job Documentation on 14807ef wanted to post the following: View the site here This comment will be updated on new commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some documentation related suggestions, and a change to the Python function implementation for the analytical solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Made a few more suggestions.
doc/content/verification_and_validation/figures/ver-1fd_comparison_convective_heating.png
Outdated
Show resolved
Hide resolved
doc/content/verification_and_validation/figures/ver-1fd_comparison_convective_heating.png
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks! @cticenhour ready for you to review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not much to fixup here - good review @chaibhave! A few things I wanted to comment on.
Ref: #103
Co-authored-by: Chaitanya Bhave <65254651+chaibhave@users.noreply.github.com>
Update how RMSE is calculated.
Co-authored-by: Casey Icenhour <casey.icenhour@inl.gov>
Co-authored-by: Casey Icenhour <casey.icenhour@inl.gov>
All comments and discussions have been resolved. Thanks again all! |
…idual duplicates warned about during documentation builds Refs idaholab#125
Continuation of #106.
Should be merged after #124 since it refers its documentation.
(Close. #103)