Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ver-1fd case #125

Merged
merged 20 commits into from
Apr 15, 2024
Merged

Add Ver-1fd case #125

merged 20 commits into from
Apr 15, 2024

Conversation

simopier
Copy link
Collaborator

@simopier simopier commented Apr 9, 2024

Continuation of #106.

Should be merged after #124 since it refers its documentation.

(Close. #103)

@simopier simopier added the V&V Relevant to V&V label Apr 9, 2024
@simopier simopier self-assigned this Apr 9, 2024
@moosebuild
Copy link

moosebuild commented Apr 9, 2024

Job Documentation on 14807ef wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link

moosebuild commented Apr 9, 2024

Job Coverage on 14807ef wanted to post the following:

Coverage

Coverage did not change

Full coverage report

This comment will be updated on new commits.

Copy link
Collaborator

@chaibhave chaibhave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some documentation related suggestions, and a change to the Python function implementation for the analytical solution.

doc/content/verification_and_validation/ver-1fd.md Outdated Show resolved Hide resolved
doc/content/verification_and_validation/ver-1fd.md Outdated Show resolved Hide resolved
doc/content/verification_and_validation/ver-1fd.md Outdated Show resolved Hide resolved
doc/content/verification_and_validation/ver-1fd.md Outdated Show resolved Hide resolved
test/tests/ver-1fd/comparison_ver-1fd.py Show resolved Hide resolved
test/tests/ver-1fd/comparison_ver-1fd.py Outdated Show resolved Hide resolved
test/tests/ver-1fd/comparison_ver-1fd.py Show resolved Hide resolved
test/tests/ver-1fd/tests Outdated Show resolved Hide resolved
test/tests/ver-1fd/ver-1fd.i Outdated Show resolved Hide resolved
Copy link
Collaborator

@chaibhave chaibhave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Made a few more suggestions.

Copy link
Collaborator

@chaibhave chaibhave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! @cticenhour ready for you to review.

Copy link
Member

@cticenhour cticenhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much to fixup here - good review @chaibhave! A few things I wanted to comment on.

doc/content/verification_and_validation/ver-1fd.md Outdated Show resolved Hide resolved
doc/content/verification_and_validation/ver-1fd.md Outdated Show resolved Hide resolved
test/tests/ver-1fd/comparison_ver-1fd.py Show resolved Hide resolved
test/tests/ver-1fd/comparison_ver-1fd.py Show resolved Hide resolved
test/tests/ver-1fd/tests Outdated Show resolved Hide resolved
Co-authored-by: Casey Icenhour <casey.icenhour@inl.gov>
@simopier simopier merged commit 9387661 into devel Apr 15, 2024
6 checks passed
@cticenhour
Copy link
Member

All comments and discussions have been resolved. Thanks again all!

@simopier simopier deleted the ver_1fd_PC branch April 15, 2024 22:04
This was referenced Apr 16, 2024
cticenhour added a commit to cticenhour/TMAP8 that referenced this pull request Apr 22, 2024
…idual duplicates warned about during documentation builds

Refs idaholab#125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V&V Relevant to V&V
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants