Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in NodalKernel compute jacobian thread #10620

Closed
sveerara opened this issue Jan 26, 2018 · 2 comments
Closed

Bug in NodalKernel compute jacobian thread #10620

sveerara opened this issue Jan 26, 2018 · 2 comments
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@sveerara
Copy link
Contributor

sveerara commented Jan 26, 2018 •
edited

Rationale

When two child objects of nodal kernel are in the input file, the first one acting on disp_y and the second one acting on disp_x, the computeJacobian() function gets called only on the first nodal kernel object.

Description

The ComputeNodalKernelJacobiansThread and ComputeNodalKernelBCJacobiansThread call the computeOffDiagJacobian function for a set of active block and boundary restricted nodal kernels, respectively. Due to a break statement present in these two classes, the list of active nodal kernels is not correctly updated.

Impact

Minor bug fix. Should not affect any tests.
sveerara added a commit to sveerara/moose that referenced this issue Jan 26, 2018
@sveerara
Nodal kernel compute jacobian thread bug fix idaholab#10620
30cd3eb
@sveerara sveerara mentioned this issue Jan 26, 2018
Merged
sveerara added a commit to sveerara/moose that referenced this issue Jan 26, 2018
@sveerara
Nodal kernel compute jacobian thread bug fix idaholab#10620
92327b2
@permcody permcody added C: Framework T: task An enhancement to the software. P: normal A defect affecting operation with a low possibility of significantly affects. labels Jan 26, 2018
@andrsd
Copy link
Contributor

andrsd commented Jan 26, 2018

Please, do not edit the template. Need the description section. Thanks!

@sveerara
Copy link
Contributor Author

Sorry about editing the template. I will remember not to do that the next time. Thanks.

sveerara added a commit to sveerara/moose that referenced this issue Jan 26, 2018
@sveerara
Nodal kernel compute jacobian thread bug fix idaholab#10620
d8eac3c
sveerara added a commit to sveerara/moose that referenced this issue Jan 26, 2018
@sveerara
Nodal kernel compute jacobian thread bug fix idaholab#10620
c385267
permcody added a commit that referenced this issue Jan 29, 2018
@permcody
Merge pull request #10621 from sveerara/nodal_kernel_bug
885a549 
Nodal kernel compute jacobian thread bug fix #10620
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andrsd @permcody @sveerara