Nodal kernel compute jacobian thread bug fix #10620

[sveerara]

There is a break statement in both ComputeNodalKernelJacobiansThread.C and ComputeNodalKernelBCJacobiansThread.C that breaks out of the loop over nodal kernels if the first nodal kernel's variable is not equal to ivar. So, even if the second nodal kernel's variable is same as ivar, it does not get added to the active_involved_kernels list.

I removed the break statement and modified the code such that nodal kernel gets added to the list of active_nodal_kernels if its variable is same as ivar and either jvar equals ivar or jvar is one of the coupled variables.

closes #10620

[permcody]

This looks OK, any chance you can come up with a test case to make sure this stays working?

[sveerara]

Yes, I will add a test case to moose tests.

[moosebuild]

Job Documentation on c385267 wanted to post the following:

View the site here

This comment will be updated on new commits.

[moosebuild]

Job Precheck on d8eac3c wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s http://mooseframework.org/docs/PRs/10621/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 5d3b47c19ffeaf86a58b8c19bdca403111717dd2

[sveerara]

@permcody I have added two nodal kernel jacobian tests - one for block restricted and the other for boundary restricted nodal kernels.

[permcody]

Nice - Thanks for the tests!