Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation Enhancements #10745

Closed
friedmud opened this issue Feb 9, 2018 · 1 comment
Closed

Deprecation Enhancements #10745

friedmud opened this issue Feb 9, 2018 · 1 comment
Assignees
@friedmud
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@friedmud
Copy link
Contributor

friedmud commented Feb 9, 2018

Rationale

Deprecations currently cause failure that must be immediately fixed - this goes against the idea of deprecating things!

Description

We should enhance deprecations in a few ways:

  1. Add back in the idea of a removal date
  2. They should be their own special kind of warning
  3. They should NOT ever be promoted to errors automatically
  4. We should allow them to be promoted to errors by run_test - but ONLY if you explicitly provide a command-line option

Impact

Better workflow for changing API's and input file syntax.
@friedmud friedmud self-assigned this Feb 9, 2018
@permcody permcody added C: Framework T: task An enhancement to the software. P: normal A defect affecting operation with a low possibility of significantly affects. labels Feb 9, 2018
@tophmatthews
Copy link
Contributor

FYI, #6780 may go along with this.

@friedmud friedmud mentioned this issue Feb 13, 2018
Closed
friedmud added a commit to friedmud/moose that referenced this issue Feb 13, 2018
@friedmud
Revert "Remove the time bomb deprecated registration" refs idaholab#1…
66be01c 
…0745

This reverts commit ff0eb8d.
friedmud added a commit to friedmud/moose that referenced this issue Feb 13, 2018
@friedmud
Implement most of whats needed including adding new testing objects for
68448b0 
idaholab#10745
friedmud added a commit to friedmud/moose that referenced this issue Feb 13, 2018
@friedmud
Test new deprecation capabilities closes idaholab#10745
053ab7c
@friedmud friedmud mentioned this issue Feb 13, 2018
Merged
friedmud added a commit to friedmud/moose that referenced this issue Feb 13, 2018
@friedmud
Fixup testharness test closes idaholab#10745
9336e02
friedmud added a commit to friedmud/moose that referenced this issue Feb 13, 2018
@friedmud
Fixup testharness test closes idaholab#10745
5a5fa0a
friedmud added a commit to friedmud/moose that referenced this issue Feb 13, 2018
@friedmud
Revert "Remove the time bomb deprecated registration" refs idaholab#1…
b2f0695 
…0745

This reverts commit ff0eb8d.
friedmud added a commit to friedmud/moose that referenced this issue Feb 13, 2018
@friedmud
Implement most of whats needed including adding new testing objects for
7fc71d9 
idaholab#10745
friedmud added a commit to friedmud/moose that referenced this issue Feb 13, 2018
@friedmud
Fixup testharness test closes idaholab#10745
c0c0b29
friedmud added a commit to friedmud/moose that referenced this issue Feb 15, 2018
@friedmud
Address comments refs idaholab#10745
932e4bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@friedmud friedmud

Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@friedmud @permcody @tophmatthews