Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated messages only output for one deprecated object per input file #6780

Closed
tophmatthews opened this issue Apr 18, 2016 · 9 comments · Fixed by #22897
Closed

Deprecated messages only output for one deprecated object per input file #6780

tophmatthews opened this issue Apr 18, 2016 · 9 comments · Fixed by #22897
Assignees
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.

Comments

@tophmatthews
Copy link
Contributor

Description of the enhancement or error report

When multiple deprecated objects are present in an input file, a warning for only one of the objects is printed and the others ignored. This is especially unfortunate if the date of deprecation is past for one of the ignored kernels which usually throws an error

Rationale for the enhancement or information for reproducing the error

This can be repeated by deprecating the kernels in examples/ex06_transient/src/base/ExampleApp.C by

registerDeprecatedObjectName(ExampleConvection, "ExampleConvection", "11/11/2010 00:00");
registerDeprecatedObjectName(ExampleDiffusion, "ExampleDiffusion", "11/11/2010 00:00");
registerDeprecatedObjectName(ExampleTimeDerivative, "ExampleTimeDerivative", "11/11/2016 00:00");

and observing that when ex06.i is run, only the warning for ExampleTimeDerivative prints.

Identified impact

Animals with deprecated objects may see more warnings or errors as this is fixed.

@aeslaughter aeslaughter self-assigned this Apr 18, 2016
@aeslaughter aeslaughter added C: Framework T: defect An anomaly, which is anything that deviates from expectations. P: normal A defect affecting operation with a low possibility of significantly affects. labels Apr 18, 2016
@permcody
Copy link
Member

I'm sure this is due to the use of mooseDoOnce(). It might be a little tricky to fix. Perhaps we should just use rank == 0 instead.

@tophmatthews
Copy link
Contributor Author

Not a huge deal, but this issue is still valid fyi

@permcody
Copy link
Member

mooseDoOnce use to work because it declares a new local static variable. However, now that the registration is done in the global registry, it might not be working like it use to. I do consider this a bug and it should be fixed. Thanks for the report.

@tophmatthews
Copy link
Contributor Author

Also needs to be extended to AD objects

@elementx54
Copy link
Contributor

Also needs to be extended to AD objects

Would this also include things like params.addDeprecatedParam? Does that work with AD ValidParams?

@tophmatthews
Copy link
Contributor Author

In updating the master and slave terms, this shows that this is still occurs...

@GiudGiud
Copy link
Contributor

@socratesgorilla are you interested in taking that one?
I've hit it recently and it's def a problem.

@socratesgorilla
Copy link
Contributor

sure go ahead and assign

@GiudGiud
Copy link
Contributor

Great.
I think you ll need to remove a doOnce and clean up the output so that it s not crazy excessive (with the backtraces especially) with multiple deprecated params

socratesgorilla pushed a commit to socratesgorilla/moose that referenced this issue Dec 6, 2022
socratesgorilla pushed a commit to socratesgorilla/moose that referenced this issue Dec 6, 2022
socratesgorilla pushed a commit to socratesgorilla/moose that referenced this issue Dec 6, 2022
socratesgorilla pushed a commit to socratesgorilla/moose that referenced this issue Dec 6, 2022
socratesgorilla pushed a commit to socratesgorilla/moose that referenced this issue Dec 15, 2022
socratesgorilla pushed a commit to socratesgorilla/moose that referenced this issue Mar 9, 2023
socratesgorilla pushed a commit to socratesgorilla/moose that referenced this issue Apr 5, 2023
GiudGiud pushed a commit to socratesgorilla/moose that referenced this issue May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants